Messages in this thread | | | Date | Mon, 25 May 2015 19:31:18 +0300 | From | Dan Carpenter <> | Subject | Re: [PATCH 1/1] drivers: staging: rtl8192u: ieee80211: ieee80211_softmac.c: auth parse error code byte order fix |
| |
Good advice. This was actually found by Sparse and the changelog should say:
Sparse complains about this:
ieee80211_softmac.c:1561:16: warning: cast from restricted __le16 ieee80211_softmac.c:1561:16: warning: incorrect type in return expression (different base types) ieee80211_softmac.c:1561:16: expected unsigned short ieee80211_softmac.c:1561:16: got restricted __le16 [usertype] <noident>
The caller basically only cares about zero and non-zero so it doesn't affect runtime (except for making an debug message more accurate).
regards, dan carpenter
| |