lkml.org 
[lkml]   [2015]   [May]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [char-misc-next 11/11] mei: revamp mei bus code
On Thu, May 07, 2015 at 03:54:08PM +0300, Tomas Winkler wrote:
> MEI bus was designed around nfc and was hard to extend.
> Instead of hard coded way of adding the devices on the mei bus
> we scan whole me client list and create a device for each
> eligible me client; currently we support only clients with
> single connection and fixed address clients.
> NFC radio name detection is run as a fixup routine
>
> Cc: Samuel Ortiz <sameo@linux.intel.com>
> Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
> ---
> drivers/misc/mei/Makefile | 2 +-
> drivers/misc/mei/bus-fixup.c | 306 ++++++++++++++
> drivers/misc/mei/bus.c | 975 ++++++++++++++++++++++++++++---------------
> drivers/misc/mei/client.c | 9 +-
> drivers/misc/mei/init.c | 5 +-
> drivers/misc/mei/mei_dev.h | 24 +-
> drivers/misc/mei/nfc.c | 414 ------------------
> include/linux/mei_cl_bus.h | 12 +
> 8 files changed, 968 insertions(+), 779 deletions(-)
> create mode 100644 drivers/misc/mei/bus-fixup.c
> delete mode 100644 drivers/misc/mei/nfc.c

This is a lot to do in just one patch. Any chance you can split it up
into reviewable pieces?

thanks,

greg k-h


\
 
 \ /
  Last update: 2015-05-24 20:41    [W:0.201 / U:0.164 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site