lkml.org 
[lkml]   [2015]   [May]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v2 6/7] Watchdog: introduce ARM SBSA watchdog driver
    On 05/24/2015 09:13 AM, Timur Tabi wrote:
    > Fu Wei wrote:
    >> in the first timeout, just panic() maybe not enough, in [RFC]
    >> version of my patchset, I offer some option as "preaction" to use, but
    >> for simplifying the first version of driver, I have deleted them.
    >> but at least, panic() is far more useful than a simple reset. at
    >> least, it can provide the context of the crashed system to admin.
    >
    > My point is that there is very little difference between
    >
    > 1) calling panic() on pre-timeout
    > 2) calling panic() on timeout
    >

    The assumption would be that the second timeout doesn't cause a panic
    but a system reset.

    > In both cases, the system will panic. The watchdog API says that the system should reset when a timeout occurs, so you cannot call panic() before the timeout expires.
    >
    > > If you want to warn user space, that will make driver more
    > > complicated, I don't think that is a good choose for a first version.
    > > but we can find a way to improve this later
    >
    > In my opinion, this "first version" is not useful. I would like to see a pre-timeout feature that does not panic or reset when a pre-timeout occurs.
    >

    The current watchdog API suggests that the pretimeout "allows Linux
    to record useful information (like panic information and kernel
    coredumps) before it resets". The call to panic() would be the
    means to make this happen.

    Are you suggesting to change this definition ? What should it do
    instead in your opinion ?

    Thanks,
    Guenter



    \
     
     \ /
      Last update: 2015-05-24 19:01    [W:2.773 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site