Messages in this thread | | | Date | Sat, 23 May 2015 09:59:28 -0700 | Subject | Re: [PATCH v3 09/21] libnd, nd_pmem: add libnd support to the pmem driver | From | Dan Williams <> |
| |
On Sat, May 23, 2015 at 7:39 AM, Christoph Hellwig <hch@infradead.org> wrote: > On Wed, May 20, 2015 at 04:57:00PM -0400, Dan Williams wrote: >> nd_pmem attaches to persistent memory regions and namespaces emitted by >> the libnd subsystem, and, same as the original pmem driver, presents the >> system-physical-address range as a block device. >> >> The existing e820-type-12 to pmem setup is converted to a full libnd bus >> that emits an nd_namespace_io device. > > This looks completely bonkers. If you want to pretend the legacy > e820 NVDIMMs fit into your new world do that directly in > arch/x86/kernel/pmem.c instead of splitting it over two files.
I was looking to preserve the ability to keep libnd as a module, but it doesn't really matter given the small number of systems that will end up caring about X86_PMEM_LEGACY in the near term. I'll skip the platform device infrastructure and just register the pmem regions directly from arch/x86/kernel/pmem.c.
| |