lkml.org 
[lkml]   [2015]   [May]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 1/1] usb: ulpi: ulpi_init should be executed in subsys_initcall


On 05/22/2015 11:11 AM, David Cohen wrote:
> On Thu, May 21, 2015 at 08:09:54PM -0700, David Cohen wrote:
>> Hi,
>>
>> On Fri, May 22, 2015 at 10:07:05AM +0800, Lu Baolu wrote:
>>> Many drivers and modules depend on ULPI bus registeration to
>>> register ULPI interfaces and drivers. It's more appropriate
>>> to register ULPI bus in subsys_initcall instead of module_init.
>>>
>>> Kernel panic has been reported with some kind of kernel config.
>> Even though I agree subsys_initcall is better to register ulpi bus, it's
>> still no excuse to have kernel panic. What about ULPI bus being compiled
>> as module?

No kernel panic if ULPI is built as a module.

>> IMHO this is avoiding the proper kernel panic fix which should be
>> failing gracefully (or defer probe) from tusb1210 driver.
> Maybe I need to express myself better :)
> IMHO we should not consider work done with this patch only. It's still
> incomplete.

I am with you on that we should know the real problem.

I could go ahead with further debugging. Do you have any suggestions
about which direction should I go?

>
> Br, David

Thank you,
-Baolu

> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>
>



\
 
 \ /
  Last update: 2015-05-22 09:21    [W:0.061 / U:0.032 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site