lkml.org 
[lkml]   [2015]   [May]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] hugetlb: Do not account hugetlb pages as NR_FILE_PAGES
On Fri 22-05-15 16:21:43, Michal Hocko wrote:
> On Thu 21-05-15 13:09:09, Johannes Weiner wrote:
[...]
> > This makes a lot of sense to me. The only thing I worry about is the
> > proliferation of PageHuge(), a function call, in relatively hot paths.
>
> I've tried that (see the patch below) but it enlarged the code by almost
> 1k
> text data bss dec hex filename
> 510323 74273 44440 629036 9992c mm/built-in.o.before
> 511248 74273 44440 629961 99cc9 mm/built-in.o.after
>
> I am not sure the code size increase is worth it. Maybe we can reduce
> the check to only PageCompound(page) as huge pages are no in the page
> cache (yet).

Just to prevent from confusion. I means to reduce the check only for
this particular case. But that is probably not worth the troubles
either...
--
Michal Hocko
SUSE Labs


\
 
 \ /
  Last update: 2015-05-22 16:41    [W:0.235 / U:0.172 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site