lkml.org 
[lkml]   [2015]   [May]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3.16.y-ckt 068/129] arm64: KVM: Fix TLB invalidation by IPA/VMID
    Date
    3.16.7-ckt12 -stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Marc Zyngier <marc.zyngier@arm.com>

    commit 55e858b75808347378e5117c3c2339f46cc03575 upstream.

    It took about two years for someone to notice that the IPA passed
    to TLBI IPAS2E1IS must be shifted by 12 bits. Clearly our reviewing
    is not as good as it should be...

    Paper bag time for me.

    Reported-by: Mario Smarduch <m.smarduch@samsung.com>
    Tested-by: Mario Smarduch <m.smarduch@samsung.com>
    Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
    Signed-off-by: Christoffer Dall <christoffer.dall@linaro.org>
    Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
    Signed-off-by: Shannon Zhao <shannon.zhao@linaro.org>
    Signed-off-by: Luis Henriques <luis.henriques@canonical.com>
    ---
    arch/arm64/kvm/hyp.S | 1 +
    1 file changed, 1 insertion(+)

    diff --git a/arch/arm64/kvm/hyp.S b/arch/arm64/kvm/hyp.S
    index 5dfc8331c385..3aaf3bc4ad8a 100644
    --- a/arch/arm64/kvm/hyp.S
    +++ b/arch/arm64/kvm/hyp.S
    @@ -629,6 +629,7 @@ ENTRY(__kvm_tlb_flush_vmid_ipa)
    * Instead, we invalidate Stage-2 for this IPA, and the
    * whole of Stage-1. Weep...
    */
    + lsr x1, x1, #12
    tlbi ipas2e1is, x1
    /*
    * We have to ensure completion of the invalidation at Stage-2,

    \
     
     \ /
      Last update: 2015-05-22 11:21    [W:4.512 / U:2.212 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site