lkml.org 
[lkml]   [2015]   [May]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3 3/5] ata: add Broadcom AHCI SATA3 driver for STB chips
On Thu, May 21, 2015 at 03:26:10PM -0700, Brian Norris wrote:
> On Thu, May 21, 2015 at 3:20 PM, Tejun Heo <tj@kernel.org> wrote:
> > On Thu, May 21, 2015 at 07:16:07PM -0300, Fabio Estevam wrote:
> >> On Tue, May 12, 2015 at 8:28 PM, Brian Norris
> >> <computersforpeace@gmail.com> wrote:
> >>
> >> > + res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "ahci");
> >> > + ahci = devm_ioremap_resource(&pdev->dev, res);
> >> > + if (IS_ERR(ahci))
> >> > + return 0;
> >>
> >> You should propagate 'return PTR_ERR(ahci)' instead.
> >
> > Brian, can you please update the patch?
>
> Note how the function brcm_ahci_get_portmask() is used. In brcm_ahci_probe():
>
> priv->port_mask = brcm_ahci_get_portmask(pdev, priv);
> if (!priv->port_mask)
> return -ENODEV;
>
> I could try to change the return semantics if really needed. Or I
> could add some comments on brcm_ahci_get_portmask() to note its return
> semantics. Or I could just leave the driver as-is. Your call.

Ah, you're right. It's fine. Leave it alone.

Thanks.

--
tejun


\
 
 \ /
  Last update: 2015-05-22 01:01    [W:0.181 / U:0.160 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site