lkml.org 
[lkml]   [2015]   [May]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH 3/7] clocksource: mips-gic: Split clocksource and clockevent initialization
    From
    On Thu, May 21, 2015 at 2:37 PM, Ezequiel Garcia
    <ezequiel.garcia@imgtec.com> wrote:
    > This is preparation work for the introduction of clockevent frequency
    > update with a clock notifier. This is only possible when the device
    > is passed a clk struct, so let's split the legacy and devicetree
    > initialization.
    >
    > Signed-off-by: Ezequiel Garcia <ezequiel.garcia@imgtec.com>
    > ---
    > drivers/clocksource/mips-gic-timer.c | 13 ++++++++-----
    > 1 file changed, 8 insertions(+), 5 deletions(-)
    >
    > diff --git a/drivers/clocksource/mips-gic-timer.c b/drivers/clocksource/mips-gic-timer.c
    > index c4352f0..22a4daf 100644
    > --- a/drivers/clocksource/mips-gic-timer.c
    > +++ b/drivers/clocksource/mips-gic-timer.c
    > @@ -142,11 +142,6 @@ static void __init __gic_clocksource_init(void)
    > ret = clocksource_register_hz(&gic_clocksource, gic_frequency);
    > if (ret < 0)
    > pr_warn("GIC: Unable to register clocksource\n");
    > -
    > - gic_clockevent_init();
    > -
    > - /* And finally start the counter */
    > - gic_start_count();
    > }

    Instead of duplicating this bit in both the OF and non-OF paths, maybe
    it would be better to do the notifier registration in
    gic_clockevent_init(), either by passing around the struct clk or
    making it a global?


    \
     
     \ /
      Last update: 2015-05-22 01:01    [W:5.975 / U:0.036 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site