Messages in this thread | | | Date | Thu, 21 May 2015 11:50:48 -0700 | From | Andi Kleen <> | Subject | Re: [PATCH 3/4] perf: Use pmu_events_map table to create event aliases |
| |
On Wed, May 20, 2015 at 10:02:04PM -0700, Sukadev Bhattiprolu wrote: > Andi Kleen [ak@linux.intel.com] wrote: > | If you need something else in vfm to identify the CPU > | can't you just add it there? I wouldn't really call it vfm, it's > | really a "abstract cpu identifier per architecture". So if you > | need pvr just add it there. > > Ok. I will change vfm to cpuid_str and include pvr in it.
Thanks.
With that change it would be also cleaner to provide a get_cpuid_str() function by the architecture code, and then strcmp in the matching code, instead of having architecture specific compare code.
-Andi
-- ak@linux.intel.com -- Speaking for myself only
| |