lkml.org 
[lkml]   [2015]   [May]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v2 5/7] Watchdog: introduce "pretimeout" into framework
    On Thu, May 21, 2015 at 04:32:34PM +0800, fu.wei@linaro.org wrote:
    > From: Fu Wei <fu.wei@linaro.org>
    >
    > Also update Documentation/watchdog/watchdog-kernel-api.txt to
    > introduce:
    > (1)the new elements in the watchdog_device and watchdog_ops struct;
    > (2)the new API "watchdog_init_timeouts".
    >
    > Reasons:
    > (1)kernel already has two watchdog drivers are using "pretimeout":
    > drivers/char/ipmi/ipmi_watchdog.c
    > drivers/watchdog/kempld_wdt.c(but the definition is different)
    > (2)some other dirvers are going to use this: ARM SBSA Generic Watchdog
    >
    > Signed-off-by: Fu Wei <fu.wei@linaro.org>
    > ---

    [ ... ]

    >
    > +/* Use the following function to check if a pretimeout value is invalid */
    > +static inline bool watchdog_pretimeout_invalid(struct watchdog_device *wdd,
    > + unsigned int t)
    > +{
    > + return ((wdd->max_pretimeout != 0) &&
    > + (t < wdd->min_pretimeout || t > wdd->max_pretimeout));
    > +}

    Should this function also enforce "t < wdd->timeout", and
    should watchdog_timeout_invalid() enforce "t > wdd->pretimeout" ?

    Thanks,
    Guenter


    \
     
     \ /
      Last update: 2015-05-21 17:41    [W:2.864 / U:0.800 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site