Messages in this thread | | | Date | Thu, 21 May 2015 11:28:52 -0400 | From | Steven Rostedt <> | Subject | Re: [PATCH v2] rcu: Deinline rcu_read_lock_sched_held() if DEBUG_LOCK_ALLOC |
| |
On Thu, 21 May 2015 17:09:47 +0200 Denys Vlasenko <dvlasenk@redhat.com> wrote:
> --- a/kernel/rcu/update.c > +++ b/kernel/rcu/update.c > @@ -62,6 +62,55 @@ MODULE_ALIAS("rcupdate"); > > module_param(rcu_expedited, int, 0); > > +#if defined CONFIG_DEBUG_LOCK_ALLOC && defined CONFIG_PREEMPT_COUNT
I thought defined required parenthesis. Doing a
git grep '#if defined' shows most places in the kernel use it.
Although, I also did a git grep '#if defined *C' and it shows that there are quite a few places that don't use it. I would be more comfortable with adding the parenthesis and being in line with the majority of the kernel:
#if defined(CONFIG_DEBUG_LOCK_ALLOC) && defined(CONFIG_PREEMPT_COUNT)
Rest seems fine.
-- Steve
| |