Messages in this thread | | | Date | Thu, 21 May 2015 16:59:50 +0200 | From | Paolo Bonzini <> | Subject | Re: [PATCH 06/12] KVM: x86: API changes for SMM support |
| |
On 21/05/2015 16:49, Radim Krčmář wrote: > 2015-05-08 13:20+0200, Paolo Bonzini: >> diff --git a/include/uapi/linux/kvm.h b/include/uapi/linux/kvm.h >> @@ -202,7 +202,7 @@ struct kvm_run { >> __u32 exit_reason; >> __u8 ready_for_interrupt_injection; >> __u8 if_flag; >> - __u8 padding2[2]; >> + __u16 flags; > > (It got lost last review and I'd really like to know ... > what is the advantage of giving both bytes to flags?)
No advantage. You just should leave padding2[1] in the middle so that the offset of &run->padding2[0] doesn't change. Since it's not obvious I gave two bytes to flags, but I can do it either way.
Paolo
| |