Messages in this thread | | | Date | Thu, 21 May 2015 18:44:53 +0530 | From | Kishon Vijay Abraham I <> | Subject | Re: [PATCH 3/5] phy: cygnus: pcie: Define DT binding |
| |
Hi,
On Wednesday 20 May 2015 06:53 AM, Ray Jui wrote: > Add DT binding document for Broadcom Cygnus PCIe PHY driver > > Signed-off-by: Ray Jui <rjui@broadcom.com> > Reviewed-by: Arun Parameswaran <aparames@broadcom.com> > Reviewed-by: JD (Jiandong) Zheng <jdzheng@broadcom.com> > Reviewed-by: Scott Branden <sbranden@broadcom.com> > --- > .../bindings/phy/brcm,cygnus-pcie-phy.txt | 31 ++++++++++++++++++++ > 1 file changed, 31 insertions(+) > create mode 100644 Documentation/devicetree/bindings/phy/brcm,cygnus-pcie-phy.txt > > diff --git a/Documentation/devicetree/bindings/phy/brcm,cygnus-pcie-phy.txt b/Documentation/devicetree/bindings/phy/brcm,cygnus-pcie-phy.txt > new file mode 100644 > index 0000000..36745ee > --- /dev/null > +++ b/Documentation/devicetree/bindings/phy/brcm,cygnus-pcie-phy.txt
brcm-cygnus-pcie-phy.txt? > @@ -0,0 +1,31 @@ > +Broadcom Cygnus PCIe PHY > + > +Required properties: > +- compatible: Must be "brcm,cygnus-pcie-phy" > +- reg: base address and length of the CRMU block > +- #phy-cells: must be <2> > +The first cell is the PHY ID: > +0 - PCIe RC 0 > +1 - PCIe RC 1 > +The second cell is the internal PHY address > + > +Example: > + phy: phy@0301d0a0 { > + compatible = "brcm,cygnus-pcie-phy"; > + reg = <0x0301d0a0 0x14>; > + #phy-cells = <2>; > + };
IMHO these nodes should be child nodes of the mdio node. Are they modelled that way?
Thanks Kishon
| |