lkml.org 
[lkml]   [2015]   [May]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [RFC/RFT v2 0/2] power_supply: Fix NULL pointer dereference from uevent
From
Date

Am 21.05.2015 um 00:20 schrieb Sebastian Reichel <sre@kernel.org>:

> Hi,
>
> On Tue, May 19, 2015 at 10:28:39AM +0200, Dr. H. Nikolaus Schaller wrote:
>> Am 19.05.2015 um 09:13 schrieb Krzysztof Kozlowski <k.kozlowski@samsung.com>:
>>> Changes since v1:
>>> =================
>>> 1. Patch 2: fix invalid member used for container_of().
>>> 2. Patch 2: Replace WARN with pr_warn() in __power_supply_register()
>>> if parent is missing.
>>>
>>>
>>> Description:
>>> ============
>>> This is an idea to fix issue in bq27x00 driver (and probably in others)
>>> reported by H. Nikolaus Schaller [0].
>>>
>>> The fixes are marked RFC/RFT because:
>>> 1. I do not have bq27x00-like device. I confirmed this and tested on
>>> modified drivers (max77693, ACPI AC). These drivers are not
>>> impacted by the issue but one can easily adjust them to reproduce
>>> the problem.
>>> 2. The first uevent coming from power_supply_register() is now
>>> different because it won't contain device properties. I am
>>> not sure how this impacts userspace.
>>>
>>> Comments are welcomed.
>>
>> appears to work! bq27000 is coming up now without hickups.
>>
>> What I can’t test is if the uevent is reasonable because we do not
>> have a specific rule triggered by it in our system.
>>
>> So from my side we are now happy with the solution.
>
> So you would be ok with the following added to the patches?
>
> Tested-By: Dr. H. Nikolaus Schaller <hns@goldelico.com>

Yes, please add.

BR,
Nikolaus



\
 
 \ /
  Last update: 2015-05-21 08:21    [W:0.054 / U:0.176 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site