Messages in this thread | | | From | Alexandre Courbot <> | Date | Thu, 21 May 2015 14:27:59 +0900 | Subject | Re: [PATCH] serial: tegra: Fix memory leak on DMA setup failure |
| |
On Wed, May 20, 2015 at 8:21 PM, Jon Hunter <jonathanh@nvidia.com> wrote: > If the call to dmaengine_slave_config() fails, then the DMA buffer will > not be freed/unmapped. Fix this by moving the code that stores the > address of the buffer in the tegra_uart_port structure to before the > call to dmaengine_slave_config(). > > Reported-by: Alexandre Courbot <acourbot@nvidia.com> > Signed-off-by: Jon Hunter <jonathanh@nvidia.com>
Looks good, we had the same if/else condition appearing three times in this function for no real reason anyway. This considerably simplifies the code.
> drivers/tty/serial/serial-tegra.c | 32 +++++++++++--------------------- > 1 file changed, 11 insertions(+), 21 deletions(-)
Negative number of lines, another good point for this patch!
Reviewed-by: Alexandre Courbot <acourbot@nvidia.com>
| |