lkml.org 
[lkml]   [2015]   [May]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH v2 3/7] ARM64: add SBSA Generic Watchdog device node in foundation-v8.dts
Date
On Thursday 21 May 2015 16:32:32 fu.wei@linaro.org wrote:
> + watchdog0: watchdog@2a450000 {
> + compatible = "arm,sbsa-gwdt";
> + reg = <0x0 0x2a450000 0 0x10000>,
> + <0x0 0x2a440000 0 0x10000>;
> + reg-names = "refresh",
> + "control";
> + interrupts = <0 27 4>;
> + interrupt-names = "ws0";
> + timeout-sec = <10 5>;
> + };
> };
>

just one tiny comment: you can drop the 'watchdog0:' label here, there
is normally no reason to assign a label to a watchdog device, especially
if it's in a .dts file rather than a .dtsi.

The same is true for the example in the binding documentation.

Arnd


\
 
 \ /
  Last update: 2015-05-21 11:01    [from the cache]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and my Meterkast|Read the blog