Messages in this thread | | | Date | Fri, 22 May 2015 11:12:00 +0800 | From | Herbert Xu <> | Subject | Re: [PATCH net-next] bridge: allow setting hash_max + multicast_router if interface is down |
| |
On Fri, May 22, 2015 at 02:56:01AM +0200, Linus Lüssing wrote: > Network managers like netifd (used in OpenWRT for instance) try to > configure interface options after creation but before setting the > interface up. > > Unfortunately the sysfs / bridge currently only allows to configure the > hash_max and multicast_router options when the bridge interface is up. > But since br_multicast_init() doesn't start any timers and only sets > default values and initializes timers it should be save to reconfigure > the default values after that, before things actually get active after > the bridge is set up. > > With this patch hash_max and multicast_router attributes can be > changed even if the according bridge (port) is down, just like other > other bridge (port) attributes allow too. > > Signed-off-by: Linus Lüssing <linus.luessing@c0d3.blue>
Acked-by: Herbert Xu <herbert@gondor.apana.org.au> -- Email: Herbert Xu <herbert@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
| |