Messages in this thread Patch in this message | | | Subject | Re: [PATCH] regulator: core: fix constraints debug output | From | Joe Perches <> | Date | Wed, 20 May 2015 13:35:05 -0700 |
| |
On Wed, 2015-05-20 at 20:17 +0000, Stefan Wahren wrote: > In the case uV_offset is greater than 0 the debug output before > is accidentally overwritten. So take care of the output count.
If you are going to take care, please change all of these sprintf calls to snprintf.
The buf array may not be big enough [80] to hold the longest possible output string.
> diff --git a/drivers/regulator/core.c b/drivers/regulator/core.c [] > @@ -801,7 +801,7 @@ static void print_constraints(struct regulator_dev *rdev) > } > > if (constraints->uV_offset) > - count += sprintf(buf, "%dmV offset ", > + count += sprintf(buf + count, "%dmV offset ", > constraints->uV_offset / 1000); > > if (constraints->min_uA && constraints->max_uA) {
| |