lkml.org 
[lkml]   [2015]   [May]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3.10 50/65] mvsas: fix panic on expander attached SATA devices
    Date
    3.10-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: James Bottomley <JBottomley@Odin.com>

    commit 56cbd0ccc1b508de19561211d7ab9e1c77e6b384 upstream.

    mvsas is giving a General protection fault when it encounters an expander
    attached ATA device. Analysis of mvs_task_prep_ata() shows that the driver is
    assuming all ATA devices are locally attached and obtaining the phy mask by
    indexing the local phy table (in the HBA structure) with the phy id. Since
    expanders have many more phys than the HBA, this is causing the index into the
    HBA phy table to overflow and returning rubbish as the pointer.

    mvs_task_prep_ssp() instead does the phy mask using the port properties.
    Mirror this in mvs_task_prep_ata() to fix the panic.

    Reported-by: Adam Talbot <ajtalbot1@gmail.com>
    Tested-by: Adam Talbot <ajtalbot1@gmail.com>
    Signed-off-by: James Bottomley <JBottomley@Odin.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/scsi/mvsas/mv_sas.c | 5 +----
    1 file changed, 1 insertion(+), 4 deletions(-)

    --- a/drivers/scsi/mvsas/mv_sas.c
    +++ b/drivers/scsi/mvsas/mv_sas.c
    @@ -441,14 +441,11 @@ static u32 mvs_get_ncq_tag(struct sas_ta
    static int mvs_task_prep_ata(struct mvs_info *mvi,
    struct mvs_task_exec_info *tei)
    {
    - struct sas_ha_struct *sha = mvi->sas;
    struct sas_task *task = tei->task;
    struct domain_device *dev = task->dev;
    struct mvs_device *mvi_dev = dev->lldd_dev;
    struct mvs_cmd_hdr *hdr = tei->hdr;
    struct asd_sas_port *sas_port = dev->port;
    - struct sas_phy *sphy = dev->phy;
    - struct asd_sas_phy *sas_phy = sha->sas_phy[sphy->number];
    struct mvs_slot_info *slot;
    void *buf_prd;
    u32 tag = tei->tag, hdr_tag;
    @@ -468,7 +465,7 @@ static int mvs_task_prep_ata(struct mvs_
    slot->tx = mvi->tx_prod;
    del_q = TXQ_MODE_I | tag |
    (TXQ_CMD_STP << TXQ_CMD_SHIFT) |
    - (MVS_PHY_ID << TXQ_PHY_SHIFT) |
    + ((sas_port->phy_mask & TXQ_PHY_MASK) << TXQ_PHY_SHIFT) |
    (mvi_dev->taskfileset << TXQ_SRS_SHIFT);
    mvi->tx[mvi->tx_prod] = cpu_to_le32(del_q);




    \
     
     \ /
      Last update: 2015-05-02 22:21    [W:4.103 / U:0.608 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site