lkml.org 
[lkml]   [2015]   [May]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] mac802154: select CRYPTO when needed
Hello.

On 19/05/15 14:18, Arnd Bergmann wrote:
> The mac802154 subsystem uses functions from the crypto layer and correctly
> selects the individual crypto algorithms, but fails to build when the
> crypto layer is disabled altogether:
>
> crypto/built-in.o: In function `crypto_ctr_free':
> :(.text+0x80): undefined reference to `crypto_drop_spawn'
> crypto/built-in.o: In function `crypto_rfc3686_free':
> :(.text+0xac): undefined reference to `crypto_drop_spawn'
> crypto/built-in.o: In function `crypto_ctr_crypt':
> :(.text+0x2f0): undefined reference to `blkcipher_walk_virt_block'
> :(.text+0x2f8): undefined reference to `crypto_inc'
>
> To solve that, this patch also selects the core crypto code,
> like all other users of that code do.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> Found in ARM randconfig testing
>
> diff --git a/net/mac802154/Kconfig b/net/mac802154/Kconfig
> index aa462b480a39..b355989c63b3 100644
> --- a/net/mac802154/Kconfig
> +++ b/net/mac802154/Kconfig
> @@ -1,6 +1,7 @@
> config MAC802154
> tristate "Generic IEEE 802.15.4 Soft Networking Stack (mac802154)"
> depends on IEEE802154
> + select CRYPTO
> select CRC_CCITT
> select CRYPTO_AUTHENC
> select CRYPTO_CCM

Good point. I thought that would have been pulled in by CRYPTO_*
automatically. Nicely spotted.

Reviewed-by: Stefan Schmidt <stefan@osg.samsung.com>

regards
Stefan Schmidt


\
 
 \ /
  Last update: 2015-05-19 15:21    [W:0.040 / U:0.644 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site