Messages in this thread | | | Date | Tue, 19 May 2015 01:32:00 -0700 | From | Christoph Hellwig <> | Subject | Re: [PATCH for-4.2 04/14] block: factor out blkdev_issue_discard_async |
| |
On Mon, May 18, 2015 at 03:18:30PM -0400, Mike Snitzer wrote: > > And besides that generic high level sentiment I think the interface > > for blkdev_issue_discard_async is simply wrong. Either you want to keep > > the internals private and just expose a completion callback that gets > > your private data and an error, or you want to build your own bios as > > suggested above. But not one that is mostly opaque except for allowing > > the caller to hook into the submission process and thus taking over I/O > > completion. > > I'll see what I can come up with.
Another option would be to help with reviewing and testing this series: http://thread.gmane.org/gmane.linux.kernel/1947453
If we can get thast one in the submitter doesn't have to care about aligning or splitting discard (or any other) bios.
| |