Messages in this thread | | | Date | Tue, 19 May 2015 16:44:30 +0900 | From | Joonsoo Kim <> | Subject | Re: [PATCH 1/3] mm/page_alloc: don't break highest order freepage if steal |
| |
On Tue, May 12, 2015 at 09:54:51AM +0200, Vlastimil Babka wrote: > On 05/12/2015 09:51 AM, Vlastimil Babka wrote: > >> { > >> struct page *page; > >>+ bool steal_fallback; > >> > >>-retry_reserve: > >>+retry: > >> page = __rmqueue_smallest(zone, order, migratetype); > >> > >> if (unlikely(!page) && migratetype != MIGRATE_RESERVE) { > >> if (migratetype == MIGRATE_MOVABLE) > >> page = __rmqueue_cma_fallback(zone, order); > >> > >>- if (!page) > >>- page = __rmqueue_fallback(zone, order, migratetype); > >>+ if (page) > >>+ goto out; > >>+ > >>+ steal_fallback = __rmqueue_fallback(zone, order, migratetype); > > Oh and the variable can be probably replaced by calling > __rmqueue_fallback directly in the if() below.
Will do.
Thanks.
| |