lkml.org 
[lkml]   [2015]   [May]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v6 1/5] random: Blocking API for accessing nonblocking_pool
On Tue, May 19, 2015 at 04:36:58PM +0200, Stephan Mueller wrote:
> diff --git a/drivers/char/random.c b/drivers/char/random.c
> index 9cd6968..6f71354 100644
> --- a/drivers/char/random.c
> +++ b/drivers/char/random.c
> @@ -1245,6 +1245,20 @@ void get_random_bytes(void *buf, int nbytes)
> EXPORT_SYMBOL(get_random_bytes);
>
> /*
> + * Equivalent function to get_random_bytes with the difference that this
> + * function blocks the request until the nonblocking_pool is initialized.
> + */
> +void get_blocking_random_bytes(void *buf, int nbytes)
> +{
> + if (unlikely(nonblocking_pool.initialized == 0))
> + wait_event_interruptible(urandom_init_wait,
> + nonblocking_pool.initialized);
> + extract_entropy(&nonblocking_pool, buf, nbytes, 0, 0);
> +}
> +EXPORT_SYMBOL(get_blocking_random_bytes);

You still need to handle the case where wait_event_interruptible
returns an error. Otherwise this looks fine.

Thanks,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt


\
 
 \ /
  Last update: 2015-05-20 01:01    [W:0.073 / U:5.148 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site