Messages in this thread | | | Date | Mon, 18 May 2015 17:01:17 -0700 | From | Dave Hansen <> | Subject | Re: [PATCH 03/19] x86, mpx: use new tsk_get_xsave_addr() |
| |
On 05/18/2015 01:36 PM, Thomas Gleixner wrote: >> > #ifdef CONFIG_X86_INTEL_MPX >> > siginfo_t *mpx_generate_siginfo(struct pt_regs *regs, >> > - struct xsave_struct *xsave_buf); >> > -int mpx_handle_bd_fault(struct xsave_struct *xsave_buf); >> > + struct task_struct *tsk); >> > +int mpx_handle_bd_fault(struct task_struct *tsk); > So you still keep *tsk and remove it in the next patch. I guess either > ordering has its value, so no problem to do it this way.
I agree that this looks a bit goofy.
Originally, this patch just passed around 'tsk' instead of 'xsave_buf'. But I realized we could go a step further.
The way it stands, it is bisectable and been built in this configuration for a month or two. I'd really like to keep it this way if possible, even though it looks a bit goofy.
| |