lkml.org 
[lkml]   [2015]   [May]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 4/4] Staging: lustre: sparse lock warning fix
On Mon, May 18, 2015 at 08:34:51PM +0200, Adrian Remonda wrote:
> Fixed sparse warning: context imbalance in 'nrs_resource_put_safe' -
> 'different lock contexts for basic block' by releasing the lock on each
> iteration of the for loop.
>

That changelog doesn't sound correct at all. That's not a correct
motivation or explanation.

I reviewed the patch and it's likely going to cause dead locks. The code
is trying to take the spinlock for the first pointer in the array and
release it at the end. Now it takes the first pointer's spinlock a
bunch of times (dead lock) and releases it once (will not happen because
we are already dead).

regards,
dan carpenter



\
 
 \ /
  Last update: 2015-05-18 23:41    [W:0.086 / U:0.136 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site