Messages in this thread | | | Date | Mon, 18 May 2015 22:01:14 +0200 | From | Borislav Petkov <> | Subject | Re: [PATCH v5 6/6] mtrr, mm, x86: Enhance MTRR checks for KVA huge page mapping |
| |
On Mon, May 18, 2015 at 01:31:59PM -0600, Toshi Kani wrote: > Well, #2 and #3 are independent. That is, uniform can be set regardless
Not #2 and #3 above - the original #2 and #3 ones. I've written them out detailed to show what I mean.
> The caller is responsible for verifying the conditions that are safe to > create huge page.
How is the caller ever going to be able to do anything about it?
Regardless, I'd prefer to not duplicate comments and rather put a short sentence pointing the reader to the comments over mtrr_type_lookup() where this all is being explained in detail.
I'll fix it up.
-- Regards/Gruss, Boris.
ECO tip #101: Trim your mails when you reply. --
| |