Messages in this thread | | | Date | Mon, 18 May 2015 10:43:29 +0300 | From | Andrey Ryabinin <> | Subject | Re: [PATCH v2 1/5] kasan, x86: move KASAN_SHADOW_OFFSET to the arch Kconfig |
| |
On 05/16/2015 02:27 PM, Paul Bolle wrote: > On Fri, 2015-05-15 at 16:59 +0300, Andrey Ryabinin wrote: >> --- a/arch/x86/Kconfig >> +++ b/arch/x86/Kconfig > >> +config KASAN_SHADOW_OFFSET >> + hex >> + default 0xdffffc0000000000 > > This sets CONFIG_KASAN_SHADOW_OFFSET for _all_ X86 configurations, > doesn't it? >
Right.
>> --- a/lib/Kconfig.kasan >> +++ b/lib/Kconfig.kasan > >> -config KASAN_SHADOW_OFFSET >> - hex >> - default 0xdffffc0000000000 if X86_64 > > While here it used to depend, at least, on HAVE_ARCH_KASAN. But grepping > the tree shows the two places where CONFIG_KASAN_SHADOW_OFFSET is > currently used are guarded by #ifdef CONFIG_KASAN. So perhaps the > default line should actually read > default 0xdffffc0000000000 if KASAN > > after the move. Would that work? >
Yes, but I would rather add "depends on KASAN".
> > Paul Bolle > >
| |