lkml.org 
[lkml]   [2015]   [May]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC][PATCH 4/4] sched, numa: Ignore pinned tasks
On Mon, May 18, 2015 at 07:59:40PM +0530, Srikar Dronamraju wrote:
> > We should never get preferred_nid set when nr_cpus_allowed == 1, see the
> > hunk that changes task_tick_numa.
> >
> > So we set preferred = -1 on pinning, do not partake in numa balancing
> > while this is so, therefore it should still be so when we dequeue,
> > right?
>
> lets say if a thread were to do a sched_setaffinity on itself ;
> would it not call account_numa_dequeue before account_numa_enqueue?

Yes, but it would call dequeue while nr_cpus_allowed was still the 'old'
value. And it will call enqueue when its the 'new' value.

> Also setting preferred = -1 in set_cpus_allowed avoids us from setting
> it at account_numa_enqueue. account_numa_enqueue() would probably be
> called more times than set_cpus_allowed.

This is true; and that makes sense.


\
 
 \ /
  Last update: 2015-05-18 17:41    [W:0.065 / U:0.568 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site