Messages in this thread | | | Date | Mon, 18 May 2015 16:03:49 +0200 | Subject | Re: [PATCH v8 09/16] clockevents/drivers: Add STM32 Timer driver | From | Maxime Coquelin <> |
| |
2015-05-18 15:10 GMT+02:00 Daniel Lezcano <daniel.lezcano@linaro.org>: > On 05/09/2015 09:53 AM, Maxime Coquelin wrote: >> >> STM32 MCUs feature 16 and 32 bits general purpose timers with prescalers. >> The drivers detects whether the time is 16 or 32 bits, and applies a >> 1024 prescaler value if it is 16 bits. >> >> Reviewed-by: Linus Walleij <linus.walleij@linaro.org> >> Tested-by: Chanwoo Choi <cw00.choi@samsung.com> >> Signed-off-by: Maxime Coquelin <mcoquelin.stm32@gmail.com> >> --- >> drivers/clocksource/Kconfig | 8 ++ >> drivers/clocksource/Makefile | 1 + >> drivers/clocksource/timer-stm32.c | 184 >> ++++++++++++++++++++++++++++++++++++++ >> 3 files changed, 193 insertions(+) >> create mode 100644 drivers/clocksource/timer-stm32.c >> >> diff --git a/drivers/clocksource/Kconfig b/drivers/clocksource/Kconfig >> index bf9364c..2443520 100644 >> --- a/drivers/clocksource/Kconfig >> +++ b/drivers/clocksource/Kconfig >> @@ -106,6 +106,14 @@ config CLKSRC_EFM32 >> Support to use the timers of EFM32 SoCs as clock source and >> clock >> event device. >> >> +config CLKSRC_STM32 >> + bool "Clocksource for STM32 SoCs" if !ARCH_STM32 >> + depends on OF && ARM && (ARCH_STM32 || COMPILE_TEST) > > > Are the interactive bool and the 'COMPILE_TEST' necessary ? >
The interactive bool is necessary if we want to be able to select/deselect it in COMPILE_TEST configuration. And personnaly, I think COMPILE_TEST use makes sense.
Note that other timer drivers are doing the same thing today (CLKSRC_EFM32, SH_TIMER_CMT, EM_TIMER_STI...).
Do you have a specific concern regarding COMPILE_TEST?
Kind regards, Maxime
| |