lkml.org 
[lkml]   [2015]   [May]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH V3 09/13] selftests, powerpc: Add test for DSCR value inheritence across fork
On 05/18/2015 10:39 AM, Anton Blanchard wrote:
> Hi Anshuman,
>
> Thanks for getting these testcases into the kernel.
>
>> This patch adds a test to verify that the changed DSCR value inside
>> any process would be inherited to it's child process across the fork
>> system call.
>
> One issue I do notice (a bug in my original test cases too), is that we
> don't restore the DSCR on exit. I'm not sure we need to go to the
> trouble of saving and restoring it, but we should at least get it back
> to 0 when done.

Will save/restore the system DSCR default before exiting.

>
> Also a tiny nit, no need for a newline in perror():
>
> open() failed
> : Permission denied
>

sure, will remove them.

> With those changes you can add:
>
> Signed-off-by: Anton Blanchard <anton@samba.org>
>
> to the patches based on my testcases.

Thanks.



\
 
 \ /
  Last update: 2015-05-18 13:21    [W:0.057 / U:0.560 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site