Messages in this thread | | | Date | Sun, 17 May 2015 09:15:03 -0700 | From | Kenneth Westfield <> | Subject | Re: [PATCH v2 06/13] ASoC: qcom: make osr clock optional |
| |
On Sat, May 16, 2015 at 05:32:49AM -0700, Srinivas Kandagatla wrote: > Some LPASS integrations like on APQ8016 do not have OSR clk, so making > osr clk optional would allow such integrations to use lpass driver.
> @@ -415,7 +424,7 @@ int asoc_qcom_lpass_cpu_platform_probe(struct > platform_device *pdev) > dev_err(&pdev->dev, > "%s() error getting mi2s-osr-clk: %ld\n", > __func__, > - return PTR_ERR(drvdata->mi2s_osr_clk[dai_id])); > + PTR_ERR(drvdata->mi2s_osr_clk[dai_id])); > }
NIT: Perhaps make this a dev_warn or dev_notice log message, as it's no longer really an error.
-- Kenneth Westfield Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project
| |