Messages in this thread | | | Date | Sat, 16 May 2015 11:09:26 +0100 | From | Jonathan Cameron <> | Subject | Re: [PATCH v1 1/1] iio: ltr501: Fix proximity threshold boundary check |
| |
On 16/05/15 00:42, Kuppuswamy Sathyanarayanan wrote: > Currently, proximity sensor boundary check is done > inside the switch block but outside the case > statement.Since this code will never get executed, > moved the check outside the switch case statement. > > 867 case IIO_PROXIMITY: > 868 switch (dir) { > // Following line has been moved outside the switch block. > 869 if (val > LTR501_PS_THRESH_MASK) > 870 return -EINVAL; > 871 case IIO_EV_DIR_RISING: > > Signed-off-by: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com> Applied to the togreg branch of iio.git
Thanks,
Jonathan > --- > drivers/iio/light/ltr501.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/iio/light/ltr501.c b/drivers/iio/light/ltr501.c > index ca4bf47..417369b 100644 > --- a/drivers/iio/light/ltr501.c > +++ b/drivers/iio/light/ltr501.c > @@ -865,9 +865,9 @@ static int ltr501_write_thresh(struct iio_dev *indio_dev, > return -EINVAL; > } > case IIO_PROXIMITY: > - switch (dir) { > if (val > LTR501_PS_THRESH_MASK) > return -EINVAL; > + switch (dir) { > case IIO_EV_DIR_RISING: > mutex_lock(&data->lock_ps); > ret = regmap_bulk_write(data->regmap, >
| |