lkml.org 
[lkml]   [2015]   [May]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v6 04/12] irqchip: vf610-mscm: support NVIC parent
On 2015-05-15 12:39, Thomas Gleixner wrote:
> On Sat, 9 May 2015, Stefan Agner wrote:
>> - irq_chip_unmask_parent(data);
>> + if (parent->chip->irq_enable)
>> + parent->chip->irq_enable(parent);
>> + else
>> + parent->chip->irq_unmask(parent);
>
> Why are you not creating irq_chip_enable_parent() which would have
> been the proper function anyway?
>

Will add that...

Btw, have you had a chance to look at 1/12? I added a helper there too
to allow make use of generic chip with IRQ domain hierarchy. In case you
are fine with that general appraoch I will send an updated version of
the patchset with the irq_chip_enable_parent helper soon.

--
Stefan


\
 
 \ /
  Last update: 2015-05-15 19:01    [W:0.075 / U:0.080 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site