lkml.org 
[lkml]   [2015]   [May]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH][linux-next] coda: Do not define TRACE_SYSTEM_STRING
On Thu, 14 May 2015 22:52:50 -0400
Steven Rostedt <rostedt@goodmis.org> wrote:

> TRACE_SYSTEM_STRING is used internally to the TRACE_EVENT system. It
> should not be defined by tracepoint files. I'm not even sure who
> started that (I hope it wasn't me!)

According to git history, that define first showed up in

commit 1c5d22f76dc721f3acb7a3dadc657a221e487fb7
Author: Chris Wilson <chris@chris-wilson.co.uk>
Date: Tue Aug 25 11:15:50 2009 +0100

drm/i915: Add tracepoints

And it must have spread with cut and paste. Now I need to start
administering a vaccine to keep developers from catching it!

-- Steve


>
> Reported-by: kbuild test robot <fengguang.wu@intel.com>
> Signed-off-by: Steven Rostedt <rostedt@goodmis.org.
> ---
> diff --git a/drivers/media/platform/coda/trace.h b/drivers/media/platform/coda/trace.h
> index d1d06cbd1f6a..781bf7286d53 100644
> --- a/drivers/media/platform/coda/trace.h
> +++ b/drivers/media/platform/coda/trace.h
> @@ -9,8 +9,6 @@
>
> #include "coda.h"
>
> -#define TRACE_SYSTEM_STRING __stringify(TRACE_SYSTEM)
> -
> TRACE_EVENT(coda_bit_run,
> TP_PROTO(struct coda_ctx *ctx, int cmd),
>



\
 
 \ /
  Last update: 2015-05-15 05:21    [W:0.177 / U:0.088 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site