lkml.org 
[lkml]   [2015]   [May]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 1/2] tools lib traceevent: Export dynamic symbols used by traceevent plugins
On Thu, May 14, 2015 at 08:56:15PM +0800, He Kuang wrote:

SNIP

> >>It seems new targets are needed. In the v2 patch,
> >
> >hum, I dont get it.. why ?
> >
> >dynamic-list-file gets rebuilt any time plugins are rebuilt..
> >why not keep just the 'plugins' dependency?
>
> You can test your patch as following steps:
>
> $ touch ../lib/traceevent/plugin_function.c
> $ make
> CC plugin_function.o
> LD plugin_function-in.o
> LINK plugin_function.so
> GEN libtraceevent-dynamic-list
>
> perf is not rebuilt. There should be a 'GEN perf', right?

hum, right.. so this is separated bug that was there even
without your change. I tried to kick my change to address
that and ended up with what you sent in v2 ;-)

I have another comment for your v2, which I'll send right away

thanks,
jirka


\
 
 \ /
  Last update: 2015-05-14 15:41    [W:0.135 / U:0.020 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site