lkml.org 
[lkml]   [2015]   [May]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH kernel v10 10/34] vfio: powerpc/spapr: Disable DMA mappings on disabled container
    On Tue, May 12, 2015 at 01:38:59AM +1000, Alexey Kardashevskiy wrote:
    >At the moment DMA map/unmap requests are handled irrespective to
    >the container's state. This allows the user space to pin memory which
    >it might not be allowed to pin.
    >
    >This adds checks to MAP/UNMAP that the container is enabled, otherwise
    >-EPERM is returned.
    >
    >Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>
    >[aw: for the vfio related changes]
    >Acked-by: Alex Williamson <alex.williamson@redhat.com>
    >Reviewed-by: David Gibson <david@gibson.dropbear.id.au>

    Reviewed-by: Gavin Shan <gwshan@linux.vnet.ibm.com>

    Thanks,
    Gavin

    >---
    > drivers/vfio/vfio_iommu_spapr_tce.c | 6 ++++++
    > 1 file changed, 6 insertions(+)
    >
    >diff --git a/drivers/vfio/vfio_iommu_spapr_tce.c b/drivers/vfio/vfio_iommu_spapr_tce.c
    >index 40583f9..e21479c 100644
    >--- a/drivers/vfio/vfio_iommu_spapr_tce.c
    >+++ b/drivers/vfio/vfio_iommu_spapr_tce.c
    >@@ -318,6 +318,9 @@ static long tce_iommu_ioctl(void *iommu_data,
    > struct iommu_table *tbl = container->tbl;
    > unsigned long tce;
    >
    >+ if (!container->enabled)
    >+ return -EPERM;
    >+
    > if (!tbl)
    > return -ENXIO;
    >
    >@@ -362,6 +365,9 @@ static long tce_iommu_ioctl(void *iommu_data,
    > struct vfio_iommu_type1_dma_unmap param;
    > struct iommu_table *tbl = container->tbl;
    >
    >+ if (!container->enabled)
    >+ return -EPERM;
    >+
    > if (WARN_ON(!tbl))
    > return -ENXIO;
    >
    >--
    >2.4.0.rc3.8.gfb3e7d5
    >



    \
     
     \ /
      Last update: 2015-05-13 08:41    [W:4.023 / U:0.444 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site