lkml.org 
[lkml]   [2015]   [May]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 2/2] mfd: arizona: Fix incorrect Makefile conditionals
On Wed, 13 May 2015, Richard Fitzgerald wrote:

> The use of ifneq against 'n' to conditionally compile codec-specific
> parts is wrong and was resulting in all the codec tables being built
> even for deselected codecs.
>
> Signed-off-by: Richard Fitzgerald <rf@opensource.wolfsonmicro.com>
> Acked-by: Lee Jones <lee.jones@linaro.org>
> ---
> drivers/mfd/Makefile | 6 +++---
> 1 files changed, 3 insertions(+), 3 deletions(-)

Applied, thanks.

> diff --git a/drivers/mfd/Makefile b/drivers/mfd/Makefile
> index ca6d184..63743a7 100644
> --- a/drivers/mfd/Makefile
> +++ b/drivers/mfd/Makefile
> @@ -41,13 +41,13 @@ obj-$(CONFIG_MFD_ARIZONA) += arizona-core.o
> obj-$(CONFIG_MFD_ARIZONA) += arizona-irq.o
> obj-$(CONFIG_MFD_ARIZONA_I2C) += arizona-i2c.o
> obj-$(CONFIG_MFD_ARIZONA_SPI) += arizona-spi.o
> -ifneq ($(CONFIG_MFD_WM5102),n)
> +ifeq ($(CONFIG_MFD_WM5102),y)
> obj-$(CONFIG_MFD_ARIZONA) += wm5102-tables.o
> endif
> -ifneq ($(CONFIG_MFD_WM5110),n)
> +ifeq ($(CONFIG_MFD_WM5110),y)
> obj-$(CONFIG_MFD_ARIZONA) += wm5110-tables.o
> endif
> -ifneq ($(CONFIG_MFD_WM8997),n)
> +ifeq ($(CONFIG_MFD_WM8997),y)
> obj-$(CONFIG_MFD_ARIZONA) += wm8997-tables.o
> endif
> obj-$(CONFIG_MFD_WM8400) += wm8400-core.o

--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog


\
 
 \ /
  Last update: 2015-05-13 19:21    [W:0.978 / U:0.372 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site