Messages in this thread | | | Date | Wed, 13 May 2015 05:51:06 -0700 | From | "Paul E. McKenney" <> | Subject | Re: [PATCH tip/core/rcu 1/4] mce: Stop using array-index-based RCU primitives |
| |
On Wed, May 13, 2015 at 12:31:57PM +0200, Borislav Petkov wrote: > On Tue, May 12, 2015 at 02:18:41PM -0700, Paul E. McKenney wrote: > > From: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com> > > > > Because mce is arch-specific x86 code, there is little or no > > performance benefit of using rcu_dereference_index_check() over using > > smp_load_acquire(). It also turns out that mce is the only place that > > array-index-based RCU is used, and it would be convenient to drop > > this portion of the RCU API. > > > > This patch therefore changes rcu_dereference_index_check() uses to > > smp_load_acquire(), but keeping the lockdep diagnostics, and also > > changes rcu_access_index() uses to READ_ONCE(). > > > > Signed-off-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com> > > Cc: linux-edac@vger.kernel.org > > Cc: Tony Luck <tony.luck@intel.com> > > Cc: Borislav Petkov <bp@alien8.de> > > Looks good to me. > > If it is easier for you carrying it in your tree: > > Acked-by: Borislav Petkov <bp@suse.de> > > Otherwise, let me know.
Thank you, I have applied your Acked-by. Probably easier for me to carry this change, given that it needs to be applied before the later patches that remove array-index support from RCU.
Thanx, Paul
| |