lkml.org 
[lkml]   [2015]   [May]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v4 02/13] ARM: dts: exynos4: Use labels for overriding nodesin Exynos4210
W dniu 13.05.2015 o 18:02, Kukjin Kim pisze:
> On 05/11/15 22:42, Krzysztof Kozlowski wrote:
>> Usage of labels instead of full paths reduces possible mistakes when
>> overriding nodes.
>>
> Well, I'm not sure what kind of the possible mistakes you mentioned...?

One can make a mistake in path when overriding. For example we have:
exynos4.dtsi:
/ {
gic: interrupt-controller@10490000 {
...
};
}

and someone can add in child dtsi (like exynos4210.dtsi):
/ {
soc {
interrupt-controller@10490000 {
cpu-offset = <0x8000>;
}
}
}

or he can make a mistake in address.

As a result the gic node won't be properly overridden.

>
> I don't think we need to use the label for gic, combiner.

They are overridden by child DTSI. First definition is in exynos4.dtsi
and exynos4210.dtsi adds a cpu-offset.

Best regards,
Krzysztof


\
 
 \ /
  Last update: 2015-05-13 12:01    [W:0.045 / U:0.524 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site