lkml.org 
[lkml]   [2015]   [May]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v11 06/10] iommu/vt-d: datatypes and functions used for kdump
On 05/13/15 at 04:58pm, Li, ZhenHua wrote:
> Hi Dave,
>
> iommu->root_entry_old_virt is used to store the mapped old rta.
> iommu->root_entry_old_phys is used to store the physical address
> stored in registers.
> So we must not free/unmap iommu->root_entry_old_phys .

Oh, yes. I was mistaken on this. Thanks for telling.

>
> Zhenhua
> On 05/13/2015 04:56 PM, Baoquan He wrote:
> >>+
> >>+ iommu->root_entry_old_phys = q & VTD_PAGE_MASK;
> >>+ if (!iommu->root_entry_old_phys) {
> >>+ pr_err("Could not read old root entry address.");
> >>+ return -1;
> >>+ }
> >>+
> >
> >I didn't find where you call iounmap to free mapping of
> >iommu->root_entry_old_phys. Am I missing anything?
> >
> >>+ iommu->root_entry_old_virt = ioremap_cache(iommu->root_entry_old_phys,
> >>+ VTD_PAGE_SIZE);
> >>+ if (!iommu->root_entry_old_virt) {
> >>+ pr_err("Could not map the old root entry.");
> >>+ return -ENOMEM;
> >>+ }
>


\
 
 \ /
  Last update: 2015-05-13 11:21    [W:0.064 / U:27.556 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site