lkml.org 
[lkml]   [2015]   [May]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH 2/8] dmaengine: mv_xor: add support for a38x command in descriptor mode
Date
On Wednesday 13 May 2015 10:15:35 Maxime Ripard wrote:
> > Alternatively, you could leave the XOR_DESCRIPTOR_SWAP flag disabled
> > and just swap the descriptors manually like a lot of other drivers
> > do. You have to swap the mmio accesses anywya.
>
> That won't be easily doable however.
>
> Not only the endianness of the individual fields in the descriptor
> changes, but changing the endianness also swaps the fields themselves
> by pair of u32.
>
> You can see that here:
> http://lxr.free-electrons.com/source/drivers/dma/mv_xor.h#L159
>
> So I'm guessing that leaving it like it is was the more readable
> solution.

I see, yes that would get a bit ugly.

Arnd


\
 
 \ /
  Last update: 2015-05-13 11:21    [W:0.058 / U:0.264 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site