Messages in this thread Patch in this message | | | From | Colin King <> | Subject | [PATCH][V2] ti-st: handle null allocation return correctly. | Date | Tue, 12 May 2015 22:37:23 +0100 |
| |
From: Colin Ian King <colin.king@canonical.com>
static analysis with smatch picked up the following error:
get_platform_data() error: potential null dereference 'dt_pdata'. (kzalloc returns null)
Instead, the code should return NULL to avoid the following null pointer deference. Also, remove the error message as it is redundant, the caller emits an error message to alert of a failure anyhow.
Signed-off-by: Colin Ian King <colin.king@canonical.com> --- drivers/misc/ti-st/st_kim.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/misc/ti-st/st_kim.c b/drivers/misc/ti-st/st_kim.c index 18e7a03..5027b8f 100644 --- a/drivers/misc/ti-st/st_kim.c +++ b/drivers/misc/ti-st/st_kim.c @@ -752,9 +752,8 @@ static struct ti_st_plat_data *get_platform_data(struct device *dev) int len; dt_pdata = kzalloc(sizeof(*dt_pdata), GFP_KERNEL); - if (!dt_pdata) - pr_err("Can't allocate device_tree platform data\n"); + return NULL; dt_property = of_get_property(np, "dev_name", &len); if (dt_property) -- 2.1.4
| |