Messages in this thread | | | Date | Tue, 12 May 2015 14:13:33 -0700 | Subject | Re: [RFC PATCH] Drop some asm from copy_user_64.S | From | Linus Torvalds <> |
| |
On Tue, May 12, 2015 at 1:57 PM, Borislav Petkov <bp@alien8.de> wrote: > > I want to get rid of the asm glue in arch/x86/lib/copy_user_64.S which > prepares the copy_user* alternatives calls. And replace it with nice and > clean C.
Ack. I'm not a fan of the x86-64 usercopy funmctions.
That said, I think you should uninline those things, and move them from a header file to a C file (arch/x86/lib/uaccess.c?).
Move all the copy_user_generic_unrolled/string garbage there too, and keep the header file simple.
Because I think that we would actually be better off trying to inline the copy_user_generic_string() thing into the various versions (in that uaccess.c file) than try to inline the access_ok() check into the caller.
Linus
| |