[lkml]   [2015]   [May]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH 2/3] ASoC: fsl_sai: Add tdm slots operation for SAI master mode
On Mon, May 11, 2015 at 06:24:42PM +0800, Zidan Wang wrote:

> if (!sai->is_slave_mode) {
> + slot_width = sai->slot_width;
> ret = fsl_sai_set_bclk(cpu_dai, tx,
> - 2 * word_width * params_rate(params));
> + sai->slots * slot_width * params_rate(params));
> if (ret)

This seems to make TDM configuration mandatory which seems like a step
back - if it's been set up then of course we need to use it but if it's
not been configured we should be able to just infer something from
hw_params as we have been doing. Checking to see if the relevant values
have been set and falling back to using hw_params seems better.

Otherwise this looks good.
[unhandled content-type:application/pgp-signature]
 \ /
  Last update: 2015-05-12 21:01    [W:0.073 / U:0.848 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site