lkml.org 
[lkml]   [2015]   [May]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] net: deinline netif_tx_stop_all_queues(), remove WARN_ON in netif_tx_stop_queue()
On Mon, May 11, 2015 at 09:17:53PM +0200, Denys Vlasenko wrote:
> These functions compile to 60 bytes of machine code each.
> With this .config: http://busybox.net/~vda/kernel_config
> there are 617 calls of netif_tx_stop_queue()
> and 49 calls of netif_tx_stop_all_queues() in vmlinux.
>
> To fix this, remove WARN_ON in netif_tx_stop_queue()
> as suggested by davem, and deinline netif_tx_stop_all_queues().
>
> Change in code size is about 20k:
>
> text data bss dec hex filename
> 82426986 22255416 20627456 125309858 77813a2 vmlinux.before
> 82406248 22255416 20627456 125289120 777c2a0 vmlinux

nice code shrink. Looks good to me.

Acked-by: Alexei Starovoitov <ast@plumgrid.com>

btw, in the future please say [PATCH net-next] as part of subject
to make it clear what tree this patch is going to.



\
 
 \ /
  Last update: 2015-05-12 18:21    [W:0.062 / U:23.220 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site