Messages in this thread |  | | From | Rasmus Villemoes <> | | Subject | Re: [Jfs-discussion] [PATCH] fs: cleanup slight list_entry abuse | | Date | Tue, 12 May 2015 14:13:25 +0200 |
| |
On Thu, Mar 19 2015, Dave Kleikamp <dave.kleikamp@oracle.com> wrote:
> On 03/19/2015 11:11 AM, Boaz Harrosh wrote: >> On 03/19/2015 01:28 PM, Rasmus Villemoes wrote: >>> list_entry is just a wrapper for container_of, but it is arguably >>> wrong (and slightly confusing) to use it when the pointed-to struct >>> member is not a struct list_head. Use container_of directly instead. >>> >>> Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk> >>> --- >>> Most of these predate git. If I'm the only one who has been confused >>> by this in 10 years, maybe it's not worth the churn. >>> >> >> No you are not alone here. I have seen this once as well but did not have >> the gumption to send a fix. (The sysv.h one) >> >> I totally agree with this patch. (So many of them, bread crumbs of copy/paste >> for you ;0) > > I'm sure that was the case with jfs. > >> >> Reviewed-by: Boaz Harrosh <boaz@plexistor.com> > > Acked-by: Dave Kleikamp <dave.kleikamp@oracle.com>
Al, any chance you'd take this through the vfs tree?
Rasmus
|  |