Messages in this thread | | | Date | Tue, 12 May 2015 11:28:21 +0200 | From | Ingo Molnar <> | Subject | Re: [PATCH V2] x86: Allow built-in command line to work in early kernel init |
| |
* Matthew Garrett <matthew.garrett@coreos.com> wrote:
> Any feedback on this?
So I worry about:
- the fragmented nature of it: lots of non-obvious pieces of code will now be scattered all around arch/x86/.
- the crazy #ifdefs scattered around
- the various pieces of data scattered around
... so while I don't mind the feature in principle, but it should be centralized much better IMHO, made Kconfig invariant at least in its fragmented callbacks, with only the very strictly boot method specific details spelled out explicitly.
I have not thought much about how to achieve that :-/
Thanks,
Ingo
| |