lkml.org 
[lkml]   [2015]   [May]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH V2] x86: Allow built-in command line to work in early kernel init

* Matthew Garrett <matthew.garrett@coreos.com> wrote:

> Any feedback on this?

So I worry about:

- the fragmented nature of it: lots of non-obvious pieces of code
will now be scattered all around arch/x86/.

- the crazy #ifdefs scattered around

- the various pieces of data scattered around

... so while I don't mind the feature in principle, but it should be
centralized much better IMHO, made Kconfig invariant at least in its
fragmented callbacks, with only the very strictly boot method specific
details spelled out explicitly.

I have not thought much about how to achieve that :-/

Thanks,

Ingo


\
 
 \ /
  Last update: 2015-05-12 12:01    [W:0.081 / U:0.084 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site