lkml.org 
[lkml]   [2015]   [May]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 2/9] KVM: MMU: introduce for_each_rmap_spte()


On 12/05/2015 04:32, Xiao Guangrong wrote:
> - while ((sptep = rmap_get_first(*rmapp, &iter))) {
> - BUG_ON(!(*sptep & PT_PRESENT_MASK));
> +restart:
> + for_each_rmap_spte(rmapp, &iter, sptep) {
> rmap_printk("kvm_rmap_unmap_hva: spte %p %llx gfn %llx (%d)\n",
> sptep, *sptep, gfn, level);
>
> drop_spte(kvm, sptep);
> need_tlb_flush = 1;
> + goto restart;
> }
>

For this one, I would keep using rmap_get_first. Otherwise looks good.

Paolo


\
 
 \ /
  Last update: 2015-05-12 12:01    [W:0.176 / U:19.912 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site