lkml.org 
[lkml]   [2015]   [May]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH v3 15/22] time/posix-timers:Convert to the 64bit methods for k_clock callback functions
Date
On Monday 11 May 2015 19:20:39 Baolin Wang wrote:
> diff --git a/include/linux/timekeeping.h b/include/linux/timekeeping.h
> index 89beb62..c3345d5 100644
> --- a/include/linux/timekeeping.h
> +++ b/include/linux/timekeeping.h
> @@ -250,9 +250,9 @@ static inline void get_monotonic_boottime64(struct timespec64 *ts)
> *ts = ktime_to_timespec64(ktime_get_boottime());
> }
>
> -static inline void timekeeping_clocktai(struct timespec *ts)
> +static inline void timekeeping_clocktai(struct timespec64 *ts)
> {
> - *ts = ktime_to_timespec(ktime_get_clocktai());
> + *ts = ktime_to_timespec64(ktime_get_clocktai());
> }
>
> /*
>

I believe Thomas has already mentioned before that the change to the
timekeeping_clocktai() function is not obvious here. I'd suggest you
split out the changes here along with the posix_get_tai() that
calls it into its own patch with a good description, and leave all
the simple changes to kernel/time/posix-timers.c in a second patch.

I don't think it's necessary to split up the other changes from
this patch any further. If Thomas or someone else disagrees with this
and wants it more fine-grained, it would be good to say that now.

Arnd


\
 
 \ /
  Last update: 2015-05-12 11:21    [W:0.038 / U:0.088 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site